Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable OTR messages selection when exporting messages #34220

Merged
merged 11 commits into from
Dec 20, 2024
Merged

feat: Disable OTR messages selection when exporting messages #34220

merged 11 commits into from
Dec 20, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 18, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

Due the nature of the feature, should not be possible to export OTR messages. This PR aims to disable OTR messages when selecting messages to exporting messages.

Issue(s)

Steps to test or reproduce

Further comments

CORE-899

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 18, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 7.2.0 milestone Dec 18, 2024
@dougfabris dougfabris changed the title feat: Hide export messages when the room has OTR session feat: Hide export messages when room has OTR session Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34220/
on branch gh-pages at 2024-12-20 18:13 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (24170d9) to head (0674ac8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34220   +/-   ##
========================================
  Coverage    59.28%   59.28%           
========================================
  Files         2821     2820    -1     
  Lines        67938    67931    -7     
  Branches     15105    15101    -4     
========================================
- Hits         40278    40274    -4     
  Misses       24831    24831           
+ Partials      2829     2826    -3
Flag Coverage Δ
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0674ac8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title feat: Hide export messages when room has OTR session feat: Disable OTR messages selection when exporting messages Dec 20, 2024
@dougfabris dougfabris marked this pull request as ready for review December 20, 2024 18:25
@dougfabris dougfabris requested a review from a team as a code owner December 20, 2024 18:25
gabriellsh
gabriellsh approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 🥇

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 20, 2024
@kodiakhq kodiakhq bot merged commit ff04c19 into develop Dec 20, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/hide-exportMessages branch December 20, 2024 20:40
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dougfabris @gabriellsh @jessicaschelly